Repository navigation
Fix NumPy serialization, Arrow schemas, and publisher isolation - #299
Merged
Merged
Conversation
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
This was referenced Nov 14, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #299 +/- ##
==========================================
+ Coverage 93.85% 93.89% +0.04%
==========================================
Files 205 205
Lines 22944 23126 +182
Branches 1511 1517 +6
==========================================
+ Hits 21533 21715 +182
+ Misses 1120 1119 -1
- Partials 291 292 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Consolidates #296, #297, and #298, including their original fixes and regression tests by @pengpengyi92.
Adversarial review found that the nested
TypeAdapterin #296 discards enclosing-model serialization configuration and the caller-providedfallback. Replace it with a guarded recursive core schema that stays inside the Pydantic serialization pipeline. Additional regression coverage checks model byte encoding, caller fallback, serializers that accept coerced integers, and list-subclass items. The guard works on Pydantic 2.6 as well as current releases.No dependency changes, version bump, or unrelated registry/validation changes. One commit signed off by Tim Paine; no co-author trailer.
Type of Change
Validation
test_union_fielddeselected. The skips cover serialization APIs unavailable in that version.make lint, fresh wheel/sdist builds,check-dist --pre-built,twine check, andgit diff --checkpass.Two existing failures were reproduced against untouched main at
83f2b0a:TestRegistryLoadingErrors.test_bad_class_error: its assertion requires Hydra-specific error wording. The remaining 1,631 tests and 87 subtests pass, with two skips.test_union_fieldfails when a dictionary reaches the ndarray serializer. Native array validation is unchanged here.Neither baseline assertion was weakened or removed.
Checklist
make lint)